Conversation
topolarity
reviewed
Dec 2, 2025
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
IanButterworth
approved these changes
Dec 2, 2025
Member
IanButterworth
left a comment
There was a problem hiding this comment.
Thanks, apologies. How did this slip through CI for so long?
Member
I suspect |
Member
|
I'm assuming this should be backported to v1.13, in addition to v1.12 |
KristofferC
pushed a commit
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com> (cherry picked from commit 841148d)
KristofferC
pushed a commit
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com> (cherry picked from commit 841148d)
KristofferC
pushed a commit
that referenced
this pull request
Dec 16, 2025
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com> (cherry picked from commit 841148d)
KristofferC
pushed a commit
that referenced
this pull request
Dec 16, 2025
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com> (cherry picked from commit 841148d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently assume that we have two threadspools, but the code above the mallocchanges the
jl_options.nthreadpoolsbefore we had:
Fixes #60298